RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build
Bernhard Urban-Forster
burban at openjdk.java.net
Tue Oct 6 18:17:21 UTC 2020
I organized this PR so that each commit contains the warning emitted by MSVC as commit message and its relevant fix.
Verified on
* Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
* Windows+ARM64: `{hotspot,jdk,langtools}:tier1`, no (new) failures.
* internal macOS+ARM64 port: build without `--disable-warnings-as-errors` still works. Just mentioning this here, because
it's yet another toolchain (Xcode / clang) that needs to be kept happy [going
forward](https://openjdk.java.net/jeps/391).
-------------
Commit messages:
- ./src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp(1123): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
- ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1312): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data
- ./src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp(2472): warning C4312: 'type cast': conversion from 'unsigned int' to 'address' of greater size
- ./src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp(1527): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
- ./src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(2901): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
- ./src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(2756): warning C4146: unary minus operator applied to unsigned type, result still unsigned
- ./src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp(1837): warning C4267: 'initializing': conversion from 'size_t' to 'unsigned int', possible loss of data
- ./src/hotspot/cpu/aarch64/immediate_aarch64.cpp(72): warning C4146: unary minus operator applied to unsigned type, result still unsigned
- ./src/hotspot/cpu/aarch64/frame_aarch64.cpp(716): warning C4146: unary minus operator applied to unsigned type, result still unsigned
- ./src/hotspot/cpu/aarch64/frame_aarch64.cpp(686): warning C4477: 'printf' : format string '%016lx' requires an argument of type 'unsigned long', but variadic argument 1 has type 'uintptr_t'
- ... and 4 more: https://git.openjdk.java.net/jdk/compare/91997838...3e92e29f
Changes: https://git.openjdk.java.net/jdk/pull/530/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=530&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8254072
Stats: 22 lines in 9 files changed: 1 ins; 0 del; 21 mod
Patch: https://git.openjdk.java.net/jdk/pull/530.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/530/head:pull/530
PR: https://git.openjdk.java.net/jdk/pull/530
More information about the hotspot-dev
mailing list