RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v3]

Thomas Stuefe stuefe at openjdk.java.net
Wed Oct 7 08:38:11 UTC 2020


On Wed, 7 Oct 2020 08:11:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix comments
>
> Hi Coleen,
> 
> this is a nice cleanup. Not a full review yet.
> 
> Also some of my remarks are probably follow ups (if that), I leave that up to you how much you want to take from my
> review.
> Cheers, Thomas

Github seems to order code comments by time, not by line number; this is not ideal :(

-------------

PR: https://git.openjdk.java.net/jdk/pull/522


More information about the hotspot-dev mailing list