RFR: 8254166: Zero: return-type warning in zeroInterpreter_zero.cpp [v2]

[Severin Gehwolf]

On Wed, 7 Oct 2020 15:57:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> This breaks 11u without disabled warnings as errors, but the issue exists in head JDK as well. Might as well fix it
>> everywhere.
>> Testing:
>>   - [x] Linux ARM32 Zero build on HEAD JDK
>>   - [x] Linux ARM32 Zero build on 11u
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added comment

Looks OK to me. I'd suggest adding a comment as the return after `ShouldNotReachHere()` looks odd otherwise.

src/hotspot/cpu/zero/zeroInterpreter_zero.cpp line 143:

> 141:     default:
> 142:       ShouldNotReachHere();
> 143:       return result;

Perhaps add a `// silence compiler` comment to the return?

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/545