RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v5]

[Coleen Phillimore]

On Wed, 7 Oct 2020 15:52:58 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added some const to StackOverflow declarations
>
> src/hotspot/share/runtime/stackOverflow.hpp line 34:
> 
>> 32:
>> 33: // StackOverflow handling is encapsulated in this class.  This class contains state variables
>> 34: // for each JavaThread that implement stack overflow checking and guard page implementation.
> 
> This clause doesn't read quite right... Perhaps:
> 
> `// for each JavaThread that implement stack overflow checking and guard page functionality.`
> 
> The "that implement" and "guard page implementation." phrases in the same clause
> just don't read right... Your call on making a change here.

// StackOverflow handling is encapsulated in this class.  This class contains state variables
// for each JavaThread that are used to detect stack overflow though explicit checks or through
// checks in the signal handler when stack banging into guard pages causes a trap.
// The state variables also record whether guard pages are enabled or disabled.

Does this sound better?  It's more descriptive but hopefully still summarizing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/522