RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v5]
Coleen Phillimore
coleenp at openjdk.java.net
Wed Oct 7 18:48:14 UTC 2020
On Wed, 7 Oct 2020 18:20:54 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added some const to StackOverflow declarations
>
> src/hotspot/share/runtime/stackOverflow.cpp line 38:
>
>> 36: size_t StackOverflow::_stack_shadow_zone_size = 0;
>> 37:
>> 38: void StackOverflow::initialize_stack_zone_sizes(size_t alignment) {
>
> I think you can remove the parameter and hard-code 4K inside this function. The reason is that the "StackXXXPages"
> parameters are defined as "number of 4k units", not "number of pages".
Ok, I'll move the comment in os.cpp also that tells you why 4k is a thing.
-------------
PR: https://git.openjdk.java.net/jdk/pull/522
More information about the hotspot-dev
mailing list