RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v5]
Daniel D.Daugherty
dcubed at openjdk.java.net
Wed Oct 7 18:59:08 UTC 2020
On Wed, 7 Oct 2020 18:43:40 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> // StackOverflow handling is encapsulated in this class. This class contains state variables
>> // for each JavaThread that are used to detect stack overflow though explicit checks or through
>> // checks in the signal handler when stack banging into guard pages causes a trap.
>> // The state variables also record whether guard pages are enabled or disabled.
>>
>> Does this sound better? It's more descriptive but hopefully still summarizing.
>
> Re: your comment above. I did just move the code but some of the review comments are on the existing code. I did end
> up adding a function initialize_stack_zone_sizes and removing the set*zone functions as a result and changed some
> comments. And added some consts.
Re: the revised StackOverflow comment
Looks good to me.
-------------
PR: https://git.openjdk.java.net/jdk/pull/522
More information about the hotspot-dev
mailing list