RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v6]
David Holmes
dholmes at openjdk.java.net
Thu Oct 8 06:56:48 UTC 2020
On Thu, 8 Oct 2020 06:52:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This change moves the significant amount of stack overflow related code (with ascii art!) out of thread files into a
>> new file. Many of the functions are static functions and some go through JavaThread::_stack_overflow_state where
>> needed. All functions are moved and not modified except for qualification. I also added a delegating constructor to
>> JavaThread::JavaThread so reordered the assignments as initializers from JavaThread::initialize.
>> Tested with tier1-6 and builds on arm32, ppc, s390 and zero.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Revised comment
With regard to the discussion on whether "*_base()" functions are inclusive or exclusive, the stack_base() function is
exclusive and we fixed a number of checks that were incorrectly checking <= stack_base() rather than < stack_base().
See: https://bugs.openjdk.java.net/browse/JDK-8234372 and related issues.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/522
More information about the hotspot-dev
mailing list