RFR: 8253717: Relocate stack overflow code out of thread.hpp/cpp [v6]

Coleen Phillimore coleenp at openjdk.java.net
Thu Oct 8 11:29:47 UTC 2020


On Thu, 8 Oct 2020 05:03:04 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revised comment
>
> @coleenp: Looks all good to me now. Thanks for that work!
> 
> @dholmes-ora : I knew remember now the discussion as well. Seeing that it was only in February this is embarrassing :)
> I still find the fact the base values are off by one odd but having them at crooked values (page ends) would be odd
> too, so maybe its just a matter of brushing up comments.

Thank you for all the reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/522


More information about the hotspot-dev mailing list