RFR: 8254265: s390 and linux 32 bit builds broken

Coleen Phillimore coleenp at openjdk.java.net
Thu Oct 8 23:03:19 UTC 2020


On Thu, 8 Oct 2020 22:49:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> JDK-8253717 missed 2 ocurrances of JavaThread::stack_guard_zone_size() which was moved to class StackOverflow.
>> 
>> I just verified s390 build. Can anybody check linux 32 bit?
>
> Changes requested by coleenp (Reviewer).

Also could you change this too?
`diff --git a/src/hotspot/os/linux/os_linux.cpp b/src/hotspot/os/linux/os_linux.cpp
index 85560cc..cf20034 100644
--- a/src/hotspot/os/linux/os_linux.cpp
+++ b/src/hotspot/os/linux/os_linux.cpp
@@ -1935,7 +1935,7 @@ void * os::Linux::dll_load_in_vmthread(const char *filename, char *ebuf,
       StackOverflow* overflow_state = jt->stack_overflow_state();
       if (!overflow_state->stack_guard_zone_unused() &&     // Stack not yet fully initialized
           overflow_state->stack_guards_enabled()) {         // No pending stack overflow exceptions
-        if (!os::guard_memory((char *)jt->stack_end(), overflow_state->stack_guard_zone_size())) {
+        if (!os::guard_memory((char *)jt->stack_end(), StackOverflow::stack_guard_zone_size())) {
           warning("Attempt to reguard stack yellow zone failed.");
         }
       }`

-------------

PR: https://git.openjdk.java.net/jdk/pull/568


More information about the hotspot-dev mailing list