RFR: 8253899: Make IsClassUnloadingEnabled signature match specification [v2]

David Holmes dholmes at openjdk.java.net
Mon Oct 12 13:03:20 UTC 2020


On Mon, 12 Oct 2020 12:07:23 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Please review this change for hotspot and one test.
>> There is few JVMTI callback/event functions in jdk which signature doesn't match specification.
>> for example:
>> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, jboolean* enabled, ...)
>> but according to jvmti specs it should be:
>> static jvmtiError JNICALL IsClassUnloadingEnabled(const jvmtiEnv* env, ...)
>> same with ClassUnload(jvmtiEnv* jvmti_env, JNIEnv* jni_env, const char* name, ...)  in tests
>> for many years that didn't matter but with coming JEP-391 it becomes important to make it match the spec
>> https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code
>> This commit makes the above mentioned functions to have signature matching jvmti specification
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add impl of CSR JDK-8254014

Looks good.
Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/466


More information about the hotspot-dev mailing list