RFR: 8221554: aarch64 cross-modifying code

Alan Hayward github.com+4146708+a74nh at openjdk.java.net
Mon Oct 12 13:53:13 UTC 2020


On Mon, 12 Oct 2020 12:53:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

> @a74nh Please do not force-push commits on an open PR as it breaks the commit history and prevents reviewers from
> seeing what has changed since they last reviewed things. If you need to "rebase" you can just merge your branch with an
> updated master branch and push the merge commit to your personal fork. The skara tooling will flatten the commits into
> a single clean commit when integration happens. Thanks.

Not a fan of working with merge commits and I feel it gets muddled when you have history on top of a patch series (as
opposed to a single patch). However, understood - I'll make sure to merge instead of force pushing next time.

-------------

PR: https://git.openjdk.java.net/jdk/pull/428


More information about the hotspot-dev mailing list