RFR: 8254365: ciMethod.hpp should not include methodHandles.hpp

David Holmes dholmes at openjdk.java.net
Tue Oct 13 07:36:11 UTC 2020


On Tue, 13 Oct 2020 06:18:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> ciMethod.hpp includes methodHandles.hpp. This is probably a typo as ciMethod.hpp doesn't use the MethodHandles class.
> Instead, it uses methodHandle which is declared in runtime/handles.hpp.
> As usual, I had to fix a few .cpp files that used the MethodHandles class but did not explicitly include
> methodHandles.hpp.
> Tested with mach5 build tiers 1-5.

Seems okay. There are a couple of changes unrelated to the bug synopsis. :)

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/623


More information about the hotspot-dev mailing list