RFR: 8221554: aarch64 cross-modifying code [v3]

[Alan Hayward]

On Mon, 12 Oct 2020 15:04:22 GMT, Alan Hayward <github.com+4146708+a74nh at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp line 35:
>> 
>>> 33: #define inlasm_isb()    asm volatile("isb" : : : "memory")
>>> 34:
>>> 35: // Implementation of class OrderAccess.
>> 
>> This #define of inlasm_isb() looks wrong. Surely it should be in the body of OrderAccess::cross_modify_fence_impl()
>> given that it's not used anywhere else. All the extra indirection does is confuse the reader.
>
> Agreed. It was designed to fit with my patch which did the same for the dmb's - but I've closed that patch. Will fix.

Updated

-------------

PR: https://git.openjdk.java.net/jdk/pull/428