RFR: 8253402: Convert vmSymbols::SID to enum class [v4]

Ioi Lam iklam at openjdk.java.net
Tue Oct 13 20:51:27 UTC 2020


On Tue, 13 Oct 2020 15:35:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added missing #include <limits> from enumIterator.hpp
>
> src/hotspot/share/classfile/vmSymbols.hpp line 728:
> 
>> 726:
>> 727:   static constexpr int number_of_symbols() {
>> 728:     return SID_LIMIT;
> 
> SID_LIMIT includes NO_SID, so this seems to be off-by-one.

I changed NO_SID to -1 so SID_LIMIT no longer includes NO_SID.

-------------

PR: https://git.openjdk.java.net/jdk/pull/276


More information about the hotspot-dev mailing list