RFR: 8221554: aarch64 cross-modifying code

[Robbin Ehn]

On Wed, 14 Oct 2020 16:29:30 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>>> Regarding the use of cross_modify_fence(), I filed a bug last week to remove some uneeded uses of them in common code
>>> (https://bugs.openjdk.java.net/browse/JDK-8254264). Just a heads up before I send the RFR since I see some reference to
>>> them in the added comments.
>> 
>> I'm going to assume your change is just a two line change (removing the cross_modify_fence's), and I'll test that on
>> top of my patches using the VerifyCrossModifyFence flag - I'll give it a run of everything, which can take a while.
>> Plus I'll manually look at the code to to make sure I'm happy.  I think it makes sense that your patch goes in first,
>> then I can rebase and update code comments too. Let me know your pull request once you've raised it.
>
> Yes, the change just removes those extra cross_modify_fence's. Please check https://github.com/openjdk/jdk/pull/655

A question, ISB don't flush the I-cache which I thought was needed?
I would have expected something more similar to gcc clear_cache.

-------------

PR: https://git.openjdk.java.net/jdk/pull/428