RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v3]
Bernhard Urban-Forster
burban at openjdk.java.net
Thu Oct 15 18:42:16 UTC 2020
On Thu, 15 Oct 2020 17:24:56 GMT, Stuart Monteith <smonteith at openjdk.org> wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The pull request
>> now contains 20 commits:
>> - disable warning only for hotspot
>> - Merge remote-tracking branch 'upstream/master' into 8254072-fix-windows-arm64-warnings
>> - Merge remote-tracking branch 'upstream/master' into 8254072-fix-windows-arm64-warnings
>> - ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1441): warning C4267: 'argument': conversion from 'size_t' to
>> 'int', possible loss of data
>> ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1446): warning C4267: 'argument': conversion from 'size_t' to
>> 'int', possible loss of data ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1654): warning C4267: 'argument':
>> conversion from 'size_t' to 'int', possible loss of data
>> - Revert changes for "warning C4146: unary minus operator applied to unsigned type, result still unsigned"
>> - msvc: disable unary minus warning for unsigned types
>> - ./src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp(1123): warning C4267: 'initializing': conversion
>> from 'size_t' to 'int', possible loss of data
>> ./src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp(1123): warning C4267: 'initializing': conversion
>> from 'size_t' to 'const int', possible loss of data
>> - ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1312): warning C4267: 'argument': conversion from 'size_t' to
>> 'unsigned int', possible loss of data
>> ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1370): warning C4267: 'argument': conversion from 'size_t' to
>> 'int', possible loss of data ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1441): warning C4146: unary minus
>> operator applied to unsigned type, result still unsigned ./src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp(1441):
>> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
>> - ./src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp(2472): warning C4312: 'type cast': conversion from 'unsigned int'
>> to 'address' of greater size
>> - ./src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp(1527): warning C4267: 'argument': conversion from 'size_t' to
>> 'int', possible loss of data
>> - ... and 10 more: https://git.openjdk.java.net/jdk/compare/9359ff03...32e922da
>
> src/hotspot/cpu/aarch64/nativeInst_aarch64.hpp line 658:
>
>> 656: }
>> 657: }
>> 658: size_t size_in_bytes() { return 1ull << size(); }
>
> Capital ULL - I find that easer to search for and it is more consistent.
Thank you! Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/530
More information about the hotspot-dev
mailing list