RFR: JDK-8254889: name_and_sig_as_C_string usages in frame coding without ResourceMark [v2]

David Holmes dholmes at openjdk.java.net
Fri Oct 16 21:39:15 UTC 2020


On Fri, 16 Oct 2020 21:34:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Changes requested by stuefe (Reviewer).
>
> @MBaesken Please do not force-push commits to an open PR as it break the commit history. You can just make your changes
> and push as a normal commit. Github will then show the differences between each commit and allow the history to be seen
> clearly and consistently for reviewers. The skara tooling will flatten things into a single simple coherent commit when
> integrated.

As long as there is a ResourceMark in the caller there is no issue here - though the code should be documented in that
case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/698


More information about the hotspot-dev mailing list