RFR: 8249675: x86: frequency extraction from cpu brand string is incomplete

Markus Grönlund mgronlun at openjdk.java.net
Tue Oct 20 09:36:07 UTC 2020


On Mon, 19 Oct 2020 22:00:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> 
> 
> The changes seem fine, but couldn't you just use strrchr() to find the last H in the string?

Hi David,

Yes, that was my immediate change.

I thought of two counterarguments, admittedly weak, that made me decide against it:

1. If a suffix is introduced to the brand string, it could invalidate strrchr() usage.
2. If the same seek strategy is used as described in Application note 485 (left-to-right two char matching) , it is
easier to map the descriptions to the code.

Thanks
Markus

-------------

PR: https://git.openjdk.java.net/jdk/pull/736


More information about the hotspot-dev mailing list