RFR: 8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized [v2]

Vladimir Kozlov kvn at openjdk.java.net
Tue Oct 20 17:33:22 UTC 2020


On Tue, 20 Oct 2020 09:07:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Static analyzers complain that in `ControlWord::print()`, `rc`/`pc` variables might not be initialized. This never
>> happens in practice, because `rounding_control()` and `precision_control()` return the good values. We can make it
>> cleaner to silence the compiler.  Testing:
>>   - [x] Linux x86_64 tier1
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use fatal(), initialize to NULL and add comments

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/731


More information about the hotspot-dev mailing list