RFR: 8223312: Utilize handshakes instead of is_thread_fully_suspended [v2]

[Robbin Ehn]

On Tue, 20 Oct 2020 17:53:47 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>>> 
>>> 
>>> > Hi,
>>> > this is a good change, because it is a simplification and it it makes the stack walks safe by doing them as part of a
>>> > handshake. The change conflicts with #119 though. This one is ready to be pushed since last week but was delayed due to
>>> > other interferences. Would you mind me integrating #119 first? After integration it would be needed to pull 2
>>> > EscapeBarriers out of handshakes. Of course I would help do that. Thanks, Richard.
>>> 
>>> Hey Richard, go ahead and integrate your 119 first, I'll hold off and do the merge once you integrated.
>> 
>> Thanks Robbin!
>
> Hi Robbin,
> 
> for merging master after integration of #119 I'd suggest to resolve the
> conflicts by chosing the alternative from this pr and then apply
> https://github.com/reinrich/jdk/commit/6fa91e344ed5bf6d877e3f5a2d0d1920591fd441
> (is there a more elegant way to propose a patch?)
> 
> I successfully tested
> 
> make run-test TEST=test/jdk/com/sun/jdi/EATests.java
> which also covers PopFrame and ForceEarlyReturn.
> 
> More tests are running.
> 
> For night tests of our team it is unfortunately too late.
> 
> Thanks, Richard.

Thanks, I'm exploring what we need to execute the EB inside the handshake.
So far I think that really needs to go in a separate PR, since it becomes really unrelated to this.... picking up your
change.

> Hi Robbin,
> 
> for merging master after integration of #119 I'd suggest to resolve the
> conflicts by chosing the alternative from this pr and then apply
> [reinrich at 6fa91e3](https://github.com/reinrich/jdk/commit/6fa91e344ed5bf6d877e3f5a2d0d1920591fd441)
> (is there a more elegant way to propose a patch?)
> 
> I successfully tested
> 
> ```
> make run-test TEST=test/jdk/com/sun/jdi/EATests.java
> ```
> 
> which also covers PopFrame and ForceEarlyReturn.
> 
> More tests are running.
> 
> For night tests of our team it is unfortunately too late.
> 
> Thanks, Richard.

-------------

PR: https://git.openjdk.java.net/jdk/pull/729