RFR: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements Java…

[Coleen Phillimore]

On Tue, 20 Oct 2020 20:55:37 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Thanks you @coleenp!
>> Looks good, really nice delta of -800 LOC !
>
> Makes sense to me. But I have a couple of remarks/suggestions:
> - Object pinning for T_ARRAY on x86 shouldn't be needed any more since we stay in _thread_in_Java
> - Transition to _thread_in_native is pointless if we transition to _thread_in_native_trans immediately afterwards
> - I think the tests should also run on os.arch=="ppc64" | os.arch=="ppc64le" | os.arch=="s390x", but we should
>   double-check if they really work
> Thanks for taking care of all platforms!

@TheRealMDoerr Thank you for reviewing this and your comments.

- yes, I can remove object pinning since it's no longer needed.
- The transition to native is pointless but I was a bit unnerved from going from _thread_in_Java to
  _thread_in_native_trans even though there's no consistency checks to show it's an illegal transition.  On the other
  hand, the dummy transition to native isn't nice either so I'll make this change and retest.
- I can't test with ppc or s390 but can you modify the requires in the two tests in this patch and let me know if it
  works?

-------------

PR: https://git.openjdk.java.net/jdk/pull/764