RFR: JDK-8254889: name_and_sig_as_C_string usages in frame coding without ResourceMark [v2]

[David Holmes]

On 20/10/2020 11:45 pm, Matthias Baesken wrote:
> On Fri, 16 Oct 2020 21:36:22 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> As long as there is a ResourceMark in the caller there is no issue here - though the code should be documented in that
>> case.
> 
> hi David,  I checked the callers of frame  void describe(FrameValues& values, int frame_no);
> more closely and I think they are good (both  JavaThread::print_frame_layout  and trace_method_handle_stub   have a
> ResourceMark) ;   so should I place a comment  in frame.cpp  above describe (something like "Attention -callers need a
> ResourceMark") ?

Yes - also noting that the RA allocated string is returned to the caller.

Thanks,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/698
>