Integrated: 8255065: Zero: accessor_entry misses the IRIW case

Aleksey Shipilev shade at openjdk.java.net
Wed Oct 21 06:19:11 UTC 2020


On Tue, 20 Oct 2020 17:09:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> While doing a change in related area, I noticed there is no IRIW handling block in `ZeroInterpreter::accessor_entry`
> when reading volatile fields. This probably breaks PPC64 Zero.
> There is a block in `bytecodeInterpreter.cpp` for [common field
> access](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp#L1899-L1901):
>           if (cache->is_volatile()) {
>             if (support_IRIW_for_not_multiple_copy_atomic_cpu) {
>               OrderAccess::fence();
>             }
> 
> Attention @TheRealMDoerr ;)
> 
> Testing:
>  - [x] Linux x86_64 zero fastdebug build (includes jmod generation with Zero)

This pull request has now been integrated.

Changeset: bd45191f
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/bd45191f
Stats:     3 lines in 1 file changed: 3 ins; 0 del; 0 mod

8255065: Zero: accessor_entry misses the IRIW case

Reviewed-by: mdoerr

-------------

PR: https://git.openjdk.java.net/jdk/pull/766


More information about the hotspot-dev mailing list