RFR: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements Java… [v2]

Coleen Phillimore coleenp at openjdk.java.net
Wed Oct 21 11:59:27 UTC 2020


On Wed, 21 Oct 2020 09:55:21 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fixed test to run on other platforms, fixed copyrights, fixed ppc code.
>>  - Remove pin/unpin object code.
>
> src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 2192:
> 
>> 2190: 
>> 2191:     // Use that pc we placed in r_return_pc a while back as the current frame anchor.
>> 2192:     __ set_last_Java_frame(R1_SP, r_return_pc);
> 
> These 2 lines need to get moved before if (!is_critical_native) check.
> With this change, the 2 tests have passed with " | os.arch=="ppc64" | os.arch=="ppc64le" | os.arch=="s390x"" added.

Ok, I moved those lines and added the other platforms for the basic CriticalNative tests that I modified.  Thank you so much for testing this on the other platforms.

-------------

PR: https://git.openjdk.java.net/jdk/pull/764


More information about the hotspot-dev mailing list