RFR: 8223312: Utilize handshakes instead of is_thread_fully_suspended [v3]

[David Holmes]

On Wed, 21 Oct 2020 17:12:43 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1631:
>> 
>>> 1629:     _state->set_pending_step_for_popframe();
>>> 1630:     _result = JVMTI_ERROR_NONE;
>>> 1631:   }
>> 
>> I'd suggest to eliminate jt and use java_thread instead. Also because you're using java_thread in line 1626. The assertion should check if `_state->get_thread() == target` then.
>
> Especially if an assert() is added above on L1543.

Agreed - this code has become confused about what thread variables are present and their relationship.

-------------

PR: https://git.openjdk.java.net/jdk/pull/729