RFR: 8237363 remove oop iterate verification

Stefan Karlsson stefank at openjdk.java.net
Thu Oct 22 08:57:13 UTC 2020


On Thu, 22 Oct 2020 07:44:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This has two minor drawbacks for GC implementations that verify oops with their own asserts (like Shenandoah): they would call into `CollectedHeap::is_in` twice (once from shared code assert, and once from their own), and then also fail with non-rich assert (in the shared code) when something goes wrong. Of course, that can be mitigated by calling into `_raw` versions.

Yes, those are the trade-offs. Do you consider this a blocker?

I personally wouldn't mind completely removing this verification from the shared code, and let all the GCs do their own oop verification. But others have had the opposite opinion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/797


More information about the hotspot-dev mailing list