RFR: 8255271: Avoid generating duplicate interpreter entries for subword types

Coleen Phillimore coleenp at openjdk.java.net
Fri Oct 23 13:11:41 UTC 2020


On Thu, 22 Oct 2020 18:19:59 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Top-of-stack optimizations are generally missing for byte, char, short and boolean, and for several types of entry points we already avoid generating entries and instead redirect to the int variant.
> 
> This patch removes generation of "specialized" variants for byte, char, short and boolean more thoroughly after verifying they all generate the same code as their int specialization. This slightly reduces overhead of generating the interpreter and the size thereof.

Looks good to me.

src/hotspot/share/interpreter/templateInterpreter.cpp line 112:

> 110:   _entry[ztos] = ientry;
> 111:   _entry[ctos] = ientry;
> 112:   _entry[stos] = ientry;

next patch is to get rid of these entry points since I think nothing branches to them.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/816


More information about the hotspot-dev mailing list