RFR: 8255298: Remove SurvivorAlignmentInBytes functionality

Aleksey Shipilev shade at openjdk.java.net
Fri Oct 23 15:55:39 UTC 2020


On Fri, 23 Oct 2020 15:16:57 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews to remove the SurvivorAlignmentInBytes functionality? It has not been in use for a long time if ever, and can be removed. Searching the web also indicates that apart from the usual lists of all options and CRs it is never mentioned.
> 
> SurvivorAlignmentInBytes is an experimental option so no further process is required.
> 
> Testing: tier1-5
> 
> Thanks,
>   Thomas

Nifty cleanup! One nit I see:

src/hotspot/share/gc/parallel/psPromotionLAB.inline.hpp line 36:

> 34:   // assert(_state != flushed, "Sanity");
> 35:   HeapWord* obj = top();
> 36:   if (obj == NULL) {

`obj` cannot be `NULL` now? Thus the following null-check is redundant?

-------------

Changes requested by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/838


More information about the hotspot-dev mailing list