RFR: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method [v2]

[Robbin Ehn]

On Mon, 26 Oct 2020 19:04:44 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> This fix is fine by me.
>>> Kim's suggestions seems more like enhancements.
>> 
>> So is the proposed change, since nothing seems to actually be broken currently.  If we're going to touch it at all, let's touch it once and be done with it.
>
> @kimbarrett, does new version look better to you?

You can even do something like:
  // Same without DELETE_FUNC.
  template <typename LOOKUP_FUNC>
  bool remove(Thread* thread, LOOKUP_FUNC& lookup_f) {
    struct {
      void operator()(VALUE*) {}
    } ignore_del_f;
    return internal_remove(thread, lookup_f, ignore_del_f);
  }
Which I think @kimbarrett hinted.

-------------

PR: https://git.openjdk.java.net/jdk/pull/863