RFR: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method [v2]

Kim Barrett kbarrett at openjdk.java.net
Mon Oct 26 22:59:24 UTC 2020


On Mon, 26 Oct 2020 22:55:00 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement suggestions from review
>
> Marked as reviewed by kbarrett (Reviewer).

> You can even do something like:
> 
> ```
>   // Same without DELETE_FUNC.
>   template <typename LOOKUP_FUNC>
>   bool remove(Thread* thread, LOOKUP_FUNC& lookup_f) {
>     struct {
>       void operator()(VALUE*) {}
>     } ignore_del_f;
>     return internal_remove(thread, lookup_f, ignore_del_f);
>   }
> ```
> 
> Which I think @kimbarrett hinted.

Something along those lines would be fine too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/863


More information about the hotspot-dev mailing list