RFR: 8255254: Split os::reserve_memory and os::map_memory_to_file interfaces [v3]
Thomas Stuefe
stuefe at openjdk.java.net
Tue Oct 27 14:43:25 UTC 2020
On Tue, 27 Oct 2020 14:34:38 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Hi,
>>
>> Please review a change to extract map_memory_to_file interface out of reserve_memory when the latter takes file descriptor.
>>
>> The change should be a pure refactoring without changes in functionality. The only part is disturbing: a comment in original os_posix.cpp:316 seems to refer to else clause and it contradicts to the actual code.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix reviewing findings 2
LGTM.
Thanks, Thomas
-------------
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/812
More information about the hotspot-dev
mailing list