RFR: 8250637: UseOSErrorReporting times out (on Mac and Linux) [v2]

[Gerard Ziemski]

On Wed, 28 Oct 2020 07:04:40 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Only use UseOsErrorReporting on Windows
>>  - Revert "reset signal handlers to their system defaults if handling crash with UseOSErrorReporting"
>>    
>>    This reverts commit f6340643974f3e0cc3ab95fbbba51b23b8d9af31.
>
> Could you please do a small cleanup:
> 
> UseOSErrorReporting is defined as pd flag, with definitions in all os-dependent globals.. files. Unnecessarily, since the default value is always false. We could remove the pd definitions and just make this a normal flag in globals.hpp.
> 
> (Would be cleaner to move it to globals_windows.hpp but this would probably need a csr since its a product flag)

Thank you Thomas and David, I'm learning a lot from your reviews!

Can you please take a look at the current fix in Webrevs section? (the trivial change - make it Windows only fix, but don't remove the flag yet from other platforms)

-------------

PR: https://git.openjdk.java.net/jdk/pull/813