RFR: 8255285: Move JVMFlag origins into a new enum JVMFlagOrigin [v3]

Ioi Lam iklam at openjdk.java.net
Thu Oct 29 05:37:06 UTC 2020


> Many JVM function take an `JVMFlag::Flags` parameter to indicate the origin of the flag -- i.e., "who is setting this flag". E.g., in arguments.hpp:
> 
> static bool parse_argument(const char* arg, JVMFlag::Flags origin);
> 
> However, `JVMFlag::Flags` contains many other bits that are unrelated to the origin. We should add a new enum `JVMFlagOrigin` that has only the valid values for the origin. This makes it possible to do more type-safety checks at C++ compilation time.
> 
> This patch also renamed the confusing bit `JVMFlag::ORIG_COMMAND_LINE` to `WAS_SET_IN_COMMAND_LINE` and added documentation, so that it won't be confused with `JVMFlagOrigin::COMMAND_LINE`.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - fixed build
 - Merge branch 'master' into 8255285-new-enum-JVMFlagOrigin
 - renamed WAS_SET_IN_COMMAND_LINE to WAS_SET_ON_COMMAND_LINE
 - Removed aliases of JVMFlagOrigin::X as JVMFlag::X
 - fixed whitespaces
 - jvmflagorigin

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/823/files
  - new: https://git.openjdk.java.net/jdk/pull/823/files/53fed1b0..b1d53802

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=823&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=823&range=01-02

  Stats: 76759 lines in 1201 files changed: 56580 ins; 15008 del; 5171 mod
  Patch: https://git.openjdk.java.net/jdk/pull/823.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/823/head:pull/823

PR: https://git.openjdk.java.net/jdk/pull/823


More information about the hotspot-dev mailing list