RFR: 8255285: Move JVMFlag origins into a new enum JVMFlagOrigin [v3]

[Claes Redestad]

On Thu, 29 Oct 2020 05:37:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Many JVM function take an `JVMFlag::Flags` parameter to indicate the origin of the flag -- i.e., "who is setting this flag". E.g., in arguments.hpp:
>> 
>> static bool parse_argument(const char* arg, JVMFlag::Flags origin);
>> 
>> However, `JVMFlag::Flags` contains many other bits that are unrelated to the origin. We should add a new enum `JVMFlagOrigin` that has only the valid values for the origin. This makes it possible to do more type-safety checks at C++ compilation time.
>> 
>> This patch also renamed the confusing bit `JVMFlag::ORIG_COMMAND_LINE` to `WAS_SET_IN_COMMAND_LINE` and added documentation, so that it won't be confused with `JVMFlagOrigin::COMMAND_LINE`.
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - fixed build
>  - Merge branch 'master' into 8255285-new-enum-JVMFlagOrigin
>  - renamed WAS_SET_IN_COMMAND_LINE to WAS_SET_ON_COMMAND_LINE
>  - Removed aliases of JVMFlagOrigin::X as JVMFlag::X
>  - fixed whitespaces
>  - jvmflagorigin

Marked as reviewed by redestad (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/823