Integrated: 8255579: x86: Use cmpq(Register, Address) in safepoint_poll
Aleksey Shipilev
shade at openjdk.java.net
Thu Oct 29 12:28:46 UTC 2020
On Thu, 29 Oct 2020 08:14:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> JDK-8253180 added a new block in `safepoint_poll` that uses broken `cmpq` (JDK-8255550): it effectively does the comparison with operands swapped. It makes sense to use the non-broken `cmpq`, as to avoid changing the condition code and thus making the code less understandable. See the discussion in #910.
>
> Testing:
> - [x] `tier1` with Z (some SA tests fail, and some other fail with OOME -- seem to be expected/problem-listed)
This pull request has now been integrated.
Changeset: 4b20e460
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/4b20e460
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8255579: x86: Use cmpq(Register,Address) in safepoint_poll
Reviewed-by: eosterlund, zgu
-------------
PR: https://git.openjdk.java.net/jdk/pull/924
More information about the hotspot-dev
mailing list