RFR: 8250637: UseOSErrorReporting times out (on Mac and Linux) [v3]

[Gerard Ziemski]

On Wed, 28 Oct 2020 16:54:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make UseOSErrorReporting flag Windows only
>
> src/hotspot/share/utilities/vmError.cpp line 1437:
> 
>> 1435:   } else {
>> 1436: #if defined(_WINDOWS)
>> 1437:     // If UseOsErrorReporting we call this for each level of the call stack
> 
> Could you please change this comment to refer to UseOSErrorReporting? (Note the capital s). Makes it easier to grep for it. Same goes for os_windows.cpp:2357 .

Fixed.

> src/hotspot/share/utilities/vmError.cpp line 1631:
> 
>> 1629:   }
>> 1630: 
>> 1631: #if defined(_WINDOWS)
> 
> If you like you could abbreviate this Hunk with something like
> if (WINDOWS_ONLY(!UseOsErrorReporting) NOT_WINDOWS(true)) {
> but this is fine too, I leave it up to you.

I like it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/813