RFR: 8254309: appcds GCDuringDump.java failed - class must exist [v2]

[Yumin Qi]

On Fri, 30 Oct 2020 17:57:41 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revise as review comment, add MaxHeapSize in exit message
>
> src/hotspot/share/memory/archiveUtils.cpp line 327:
> 
>> 325:   if (exception->is_a(SystemDictionary::OutOfMemoryError_klass())) {
>> 326:     vm_exit_during_cds_dumping("Out of memory. Please run with a bigger Java heap");
>> 327:   }
> 
> I'd suggesting replacing 'bigger' with 'larger'.
> 
> I think it would be more informative if the message includes the MaxHeapSize setting.

fixed with detail message.

> test/hotspot/jtreg/runtime/cds/appcds/javaldr/GCDuringDumpTransformer.java line 108:
> 
>> 106:     public static void makeGarbage() {
>> 107:         for (int x=0; x<10; x++) {
>> 108:             Object[] a = new Object[40000];
> 
> Any reason for increasing the size by 4 times?

changed back to original value.

-------------

PR: https://git.openjdk.java.net/jdk/pull/948