RFR: 8243066 - Move VM_INTRINSICS_DO into its own vmIntrinsics.hpp file [v4]

[Coleen Phillimore]

On Wed, 16 Sep 2020 05:55:31 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

>> Relates to: https://bugs.openjdk.java.net/browse/JDK-8243066
>> Tested on: x86_64 {windows, linux, os x} x {jdk-tier1-part1..3, hotspot-tier1-gc}
>> 
>> Small change to move VM_INTRINSICS_DO out of vmSymbols.hpp into its own file.
>
> John Tortugo has refreshed the contents of this pull request, and previous commits have been removed. The incremental
> views will show differences compared to the previous content of the PR.

Changes requested by coleenp (Reviewer).

src/hotspot/share/classfile/vmIntrinsics.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved.

The copyright should just be 2020 (with trailing comma).

src/hotspot/share/classfile/vmIntrinsics.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 1997, 2020, Oracle and/or its affiliates. All rights reserved.

The copyright should start out with 2020 (with trailing comma) since this is a new file.

src/hotspot/share/classfile/vmIntrinsics.cpp line 32:

> 30: #include "compiler/compilerDirectives.hpp"
> 31: #include "memory/allocation.inline.hpp"
> 32: #include "memory/oopFactory.hpp"

Can you make sure it needs all of these header files?  I don't see a direct reference to SymbolTable:: or OopFactory.

-------------

PR: https://git.openjdk.java.net/jdk/pull/160