RFR: 8081833: Clean up JVMFlag getter/setter code

[Ioi Lam]

On Wed, 16 Sep 2020 21:05:52 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/flags/jvmFlag.hpp line 259:
>> 
>>> 257:   bool is_writeable() const       { return is_manageable();                      }
>>> 258:   // All flags except "manageable" are assumed to be internal flags.
>>> 259:   bool is_external() const        { return is_manageable();                      }
>> 
>> Do we need is_writeable() and/or is_external() if all they do is return is_manageable() ?
>
> is_external() is odd and only has one caller.  You could just fix the caller and remove is_external.

Since I am doing a "syntactic" clean up, I want to keep the code behavior the same, without doing any "semantic"
changes. The caller of `is_external()` may have a (historically) different intention than the caller of
`is_manageable()`. I want to leave such clean up in separate RFEs.

-------------

PR: https://git.openjdk.java.net/jdk/pull/163