RFR: 8253271: vm_version_x86.hpp should not include globals_extension.hpp
Ioi Lam
iklam at openjdk.java.net
Thu Sep 17 05:15:49 UTC 2020
[vm_version_x86.hpp](https://github.com/openjdk/jdk/blob/b87a1599674b8a73f489330decf051d1be9e9fba/src/hotspot/cpu/x86/vm_version_x86.hpp#L30)
is a popular header file (which in itself is a problem but I'll fix that in a separate RFE) and it unnecessarily
includes globals_extension.hpp.
Removing this dependency reduces the number of cpp files that include globals_extension.hpp from 814 to 67.
I need to fix cpp files that use macros like FLAG_SET_ERGO but forgot to include globals_extension.hpp.
-------------
Commit messages:
- 8253271: vm_version_x86.hpp should not include globals_extension.hpp
Changes: https://git.openjdk.java.net/jdk/pull/217/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=217&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8253271
Stats: 29 lines in 26 files changed: 24 ins; 2 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/217.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/217/head:pull/217
PR: https://git.openjdk.java.net/jdk/pull/217
More information about the hotspot-dev
mailing list