RFR: 8253271: vm_version_x86.hpp should not include globals_extension.hpp

David Holmes dholmes at openjdk.java.net
Thu Sep 17 06:31:51 UTC 2020


On Thu, 17 Sep 2020 05:05:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> [vm_version_x86.hpp](https://github.com/openjdk/jdk/blob/b87a1599674b8a73f489330decf051d1be9e9fba/src/hotspot/cpu/x86/vm_version_x86.hpp#L30)
> is a popular header file (which in itself is a problem but I'll fix that in a separate RFE) and it unnecessarily
> includes globals_extension.hpp.  Removing this dependency reduces the number of cpp files that include
> globals_extension.hpp from 814 to 67.
> I need to fix cpp files that use macros like FLAG_SET_ERGO but forgot to include  globals_extension.hpp.

Looks good - and trivial assuming all builds are good.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/217


More information about the hotspot-dev mailing list