RFR: 8212107: VMThread issues and cleanup [v2]

[Robbin Ehn]

On Fri, 18 Sep 2020 21:25:25 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since
>> the last revision:
>>  - Merge branch 'master' into 8212107-vmthread
>>  - Fixed nits
>>  - Merge branch 'master' into 8212107-vmthread
>>  - Fixes after review from shipilev.
>>  - Fixed some indent misses
>>  - Fixed ws
>>  - Added assert
>>  - Restructured and simplified
>>  - Removed used linking in VM_Operation
>>  - Removed ticket and use only one Monitor
>>  - ... and 2 more: https://git.openjdk.java.net/jdk/compare/2805a31f...e49178a4
>
> src/hotspot/share/runtime/vmThread.hpp line 115:
> 
>> 113:   // Performance measurement
>> 114:   static PerfCounter* perf_accumulated_vm_operation_time()
>> 115:     { return _perf_accumulated_vm_operation_time; }
> 
> Why was this broken into two lines? If keeping that, then
> the '{' belong on L114 at the end and not on L115.

This line is very long and kept bugging me. Fixed '{'.

> src/hotspot/share/runtime/vmThread.cpp line 240:
> 
>> 238:   {
>> 239:     MonitorLocker ml(_terminate_lock, Mutex::_no_safepoint_check_flag);
>> 240:     while(!VMThread::is_terminated()) {
> 
> Not your bug, but can you add a space before the '('?

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/228