RFR: 8253407: Move max_pow2 from test to src

Kim Barrett kbarrett at openjdk.java.net
Mon Sep 21 09:44:12 UTC 2020


On Mon, 21 Sep 2020 08:59:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Small refactoring to move test utility function over to src, so that it can be used in both places.
> 
> Patch summary:
> - Moved the code
> - Replaced duplicate code in round_power_of_2
> - Adjusted to the surrounding powerOfTwo.hpp code and only accept integral types.
> - Added small gtest. (On the fence whether it's worth it or not)

Looks good.  The gtest seems fine, and it's already written.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/279


More information about the hotspot-dev mailing list