RFR: 8212107: VMThread issues and cleanup [v4]

Robbin Ehn rehn at openjdk.java.net
Wed Sep 23 15:38:16 UTC 2020


On Wed, 23 Sep 2020 15:25:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after Shipilev
>
> src/hotspot/share/runtime/vmThread.cpp line 382:
> 
>> 380:
>> 381:   VM_Operation* prev_vm_operation = NULL;
>> 382:   if (_cur_vm_operation!= NULL) {
> 
> Whitespace before `!=`?

Fixing!

> src/hotspot/share/runtime/vmThread.hpp line 109:
> 
>> 107:   static VM_Operation::VMOp_Type vm_op_type()     {
>> 108:     VM_Operation* op = vm_operation();
>> 109:     assert (op != NULL, "sanity");
> 
> Should be no whitespace after `assert`?

Fixing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/228


More information about the hotspot-dev mailing list