RFR: 8253539: Remove unused JavaThread functions for set_last_Java_fp/pc
David Holmes
dholmes at openjdk.java.net
Wed Sep 23 23:09:52 UTC 2020
On Wed, 23 Sep 2020 15:12:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> These functions are also unused and in the thread_platform.hpp files. _last_Java_sp and _last_Java_fp are set in the
> assembly code for platforms that use these (x86, arm32 and aarch64). The shared runtime code never sets these, or
> should it. last_Java_fp() is always called through JavaFrameAnchor, so that function is not needed.
> last_Java_fp_offset() is used and needs to be in these platform dependent files because not all platforms save
> last_Java_fp. Tested with build on arm32 and tier1 on Oracle platforms including aarch64.
Seems okay.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/324
More information about the hotspot-dev
mailing list