RFR: 8253555: Make ByteSize and WordSize typed scoped enums [v2]

[Kim Barrett]

On Thu, 24 Sep 2020 10:59:48 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> It's a common bug in HotSpot that byte values are used when the code asks for words, and vice versa. One attempt to
>> prevent that has been to use the classes ByteSize and WordSize, to make the compiler detect these problems. The current
>> implementation is a bit problematic, because both types are int typedefs in release builds, and wrapper classes in
>> debug builds. This means that we can't use these types in overload resolution. I propose that we fix that by changing
>> the type to scoped enums with a fixed int type. The compiler will then be apple to completely separate ByteSize,
>> WordSize, and ints. We also don't need different code in release vs debug builds.  FWIW, I once created a size_t
>> versions of these classes and annotated all the metaspace code with these types. This experiment flushed out a handful
>> of bugs (some of them were known and the reason for trying that experiment)  There are some controversy about having
>> these classes around. See for example: JDK-8041956: remove ByteSize and WordSize classes  I hope we can stay away from
>> that discussion in this PR.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review 1

I'd intended suggesting the AsmOperand didn't need to be #ifdef ASSERT anymore, but forgot about that when suggesting
removing the in_bytes conversion for const_offset.  You figured out what I wanted despite that.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/328