RFR: 8253638: Cleanup os::reserve_memory and remove MAP_FIXED

Stefan Karlsson stefank at openjdk.java.net
Fri Sep 25 13:24:55 UTC 2020


On Fri, 25 Sep 2020 12:19:46 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/os/bsd/os_bsd.cpp line 2026:
>> 
>>> 2024: static char* anon_mmap(char* requested_addr, size_t bytes) {
>>> 2025:   int flags = MAP_PRIVATE | MAP_NORESERVE | MAP_ANONYMOUS;
>>> 2026:
>> 
>> Could you add a short oneliner comment here (and in front of the other mmap calls) that MAP_FIXED is explicitly left
>> out?
>
> Also, flags could possibly be const now (linux too). Leave that up to you.

Sure.

-------------

PR: https://git.openjdk.java.net/jdk/pull/357


More information about the hotspot-dev mailing list