RFR: 8253639: Change os::attempt_reserve_memory_at parameter order
Thomas Stuefe
stuefe at openjdk.java.net
Fri Sep 25 13:48:00 UTC 2020
On Fri, 25 Sep 2020 13:26:30 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> I propose that we change the parameter order from:
> os::attempt_reserve_memory_at(size, addr, <extra params>)
>
> to:
> os::attempt_reserve_memory_at(addr, size, <extra params>)
>
> This patch builds upon the changes in pull/357. There's currently no way to create an incremental review, but I want to
> get this out for review now. So, unfortunately you have to ignore the first commit and look at the second commit.
Looks good to me.
I still learn to skara and just noticed that as a reviewer I cannot use /reviewer. Since this PR contains commits from
some other PR, I don't know how to mark this as reviewed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/359
More information about the hotspot-dev
mailing list