RFR: 8253638: Cleanup os::reserve_memory and remove MAP_FIXED

Stefan Karlsson stefank at openjdk.java.net
Fri Sep 25 13:55:09 UTC 2020


On Fri, 25 Sep 2020 13:22:35 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/runtime/os.hpp line 322:
>> 
>>> 320:   // if file_desc != -1, also attaches the memory to the file.
>>> 321:   static char*  reserve_memory_with_fd(size_t bytes, size_t alignment_hint, int file_desc);
>>> 322:
>> 
>> I like that you split those two apart. The fd parameter in reserve_memory really bugged me. Should we do this also for
>> attempt_reserve_memory_at?
>
> Yes, I was thinking about that, but wanted to slice this into easily reviewed parts.

Created JDK-8253652.

-------------

PR: https://git.openjdk.java.net/jdk/pull/357


More information about the hotspot-dev mailing list