RFR: 8253639: Change os::attempt_reserve_memory_at parameter order
Stefan Karlsson
stefank at openjdk.java.net
Fri Sep 25 14:00:32 UTC 2020
On Fri, 25 Sep 2020 13:45:36 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> I propose that we change the parameter order from:
>> os::attempt_reserve_memory_at(size, addr, <extra params>)
>>
>> to:
>> os::attempt_reserve_memory_at(addr, size, <extra params>)
>>
>> This patch builds upon the changes in pull/357. There's currently no way to create an incremental review, but I want to
>> get this out for review now. So, unfortunately you have to ignore the first commit and look at the second commit.
>
> Looks good to me.
>
> I still learn to skara and just noticed that as a reviewer I cannot use /reviewer. Since this PR contains commits from
> some other PR, I don't know how to mark this as reviewed.
Thanks Thomas. You need to click "Files changed" then "Review Changes" to review this. I don't think there's a
/reviewer command you can use. I'll ask.
-------------
PR: https://git.openjdk.java.net/jdk/pull/359
More information about the hotspot-dev
mailing list